Skip to content

Let participant agent die on failed registration #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 1, 2022
Merged

Let participant agent die on failed registration #77

merged 2 commits into from
Mar 1, 2022

Conversation

ckittl
Copy link
Member

@ckittl ckittl commented Jan 11, 2022

Resolves #76

@ckittl ckittl added the bug Something isn't working label Jan 11, 2022
@ckittl ckittl requested a review from a team January 11, 2022 09:09
@ckittl ckittl self-assigned this Jan 11, 2022
@sonarqubegithubprchecks

This comment has been minimized.

Sign in to view
@codecov
Copy link

codecov bot commented Jan 11, 2022 •
edited
Loading

Codecov Report

Merging #77 (5a4ddf6) into dev (c5566e9) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev      #77      +/-   ##
==========================================
+ Coverage   79.32%   79.35%   +0.03%     
==========================================
  Files         155      155              
  Lines        5745     5746       +1     
  Branches       80       80              
==========================================
+ Hits         4557     4560       +3     
+ Misses       1188     1186       -2
Impacted Files Coverage Δ
...ent/participant/ParticipantAgentFundamentals.scala 87.95% <0.00%> (-0.30%) ⬇️
...cala/edu/ie3/simona/agent/grid/DBFSAlgorithm.scala 84.91% <0.00%> (+0.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5566e9...5a4ddf6. Read the comment docs.

@ckittl ckittl assigned johanneshiry and unassigned ckittl Jan 11, 2022
@sonarqubegithubprchecks

This comment has been minimized.

Sign in to view
sebastian-peter
sebastian-peter approved these changes Jan 25, 2022
View reviewed changes
Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. In akka typed, we'll have to think about escalating the exception in the hierarchy, as described here.

@sonarqubegithubprchecks
Copy link

Passed

Analysis Details

0 Issues

  • Bug0 Bugs
  • Vulnerability0 Vulnerabilities
  • Code Smell0 Code Smells

Coverage and Duplications

  • 0 percent coverage0.00% Coverage (81.60% Estimated after merge)
  • 3 percent duplication0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: edu.ie3:simona

View in SonarQube

t-ober
t-ober approved these changes Mar 1, 2022
View reviewed changes
Copy link
Contributor

@t-ober t-ober left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@t-ober t-ober merged commit 17a915f into dev Mar 1, 2022
@t-ober t-ober deleted the ck/#76-participantsDieOnFailedRegistration branch March 1, 2022 07:17
@sebastian-peter sebastian-peter mentioned this pull request Mar 7, 2022
Closed
@danielfeismann danielfeismann self-assigned this Mar 11, 2022
@sebastian-peter sebastian-peter added this to the Version 3.0 milestone Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastian-peter sebastian-peter sebastian-peter approved these changes

@t-ober t-ober t-ober approved these changes

Assignees

@johanneshiry johanneshiry

@danielfeismann danielfeismann

Labels
bug Something isn't working
Projects
None yet
Milestone
Version 3.0
Development

Successfully merging this pull request may close these issues.

Let participant agents die on failed registration
5 participants
@ckittl @sebastian-peter @t-ober @johanneshiry @danielfeismann